Can Vural

Results 135 comments of Can Vural

On second thought maybe it should be it's own rule, with in the bleeding edge. Because Psalm version of the tag is already in use. I'll change it.

> This feature will allow us to usefully interpret `static`. Because without consistent templates, we cannot assume how `@template` tags look above all child classes, but with consistent templates enforced,...

I added a commit to correctly infer `static` types, if the class has the tag. I think `static` only makes sense for return types. So I didn't add it to...

The current problem I'm having is that `static` return type tag is already resolved to `GenericObjectType` when docblock is resolved in `IncompatiblePhpDocTypeRule` Should I inspect the `$docComment->getText()` to figure out...

@ondrejmirtes I actually implemented all the rule changes and `GenericStaticObjectType` (maybe with some errors), but couldn't find time to clean it up and push :/ Was planning to do it...

@ondrejmirtes I pushed the changes. I did the rule changes from [here](https://github.com/phpstan/phpstan-src/pull/1289#issuecomment-1120760843). But did not implement `isSuperTypeOf` for `GenericStaticObjectType` Because I'm not sure where that check would be used. What...

@ondrejmirtes Thank you for the detailed explanation. But I already knew all that. I can implement that, and add the tests. But my question was more specific to in which...

It's fine by me. It's not urgent to get this merged. But I guess I'll spend some time on this this week. Then we'll see.

Same happens to me. From `api_blueprint` to `openapi_3`

Also it overrides the previously defined types: https://phpstan.org/r/b6723fac-0092-45ba-8b40-32e4459a44bb I know my `$matches` variable will be a string array. But PHPStan overrides that information.