dolphin-platform

dolphin-platform copied to clipboard

🆕🐥:dog: First Timers Only

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

:space_invader: Description of the issue

Currently the pom of the server module do not provide a runnable jar file by default. To define a more easy build we should change the usage of the spring-boot-maven-plugin in the pom. New plugin definition:

<plugin>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-maven-plugin</artifactId>
                <version>1.5.3.RELEASE</version>
                <executions>
                    <execution>
                        <goals>
                            <goal>repackage</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

Based on this the build (like mvn clean verify) will create a jar that can easily be started by

java -jar NAME-OF-SERVER.jar

This issue is related to the maven archetype for the Dolphin Platform that can be found here: https://github.com/canoo/dolphin-platform-spring-boot-archetype

📋 Step by Step

• 🙋 Claim this issue: Comment below.
• 🔄 replace the up for grabs label with in progress.
• :fork_and_knife: fork the repository in github by simply clicking the 'fork' button.
• :arrow_heading_down: check out the forked repository
• :twisted_rightwards_arrows: create a feature branch for the issue. We do not have any naming definition for branches.
• 💾 Commit your changes.
• 🔀 Start a Pull Request.
• 🏁 Done 👍 Ask in comments for a review :)
• 🔬 If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
• :boom: you did it! We will merge the fix in the master of the Dolphin Platform project.
• :bouquet: Thanks, thanks, thanks for being part as an open source contributor for Dolphin Platform

🤔❓ Questions

You can join our community chat at Slack

Hey guys... I want to give this a shot.

@jermsam 👍

Can i take this up?

@antrix190 it's ok. Take it up if you can do that faster. I've been assigned some project that's very demanding... May not be as fast as may be required.

@antrix190 go for it :)

@hendrikebbers I have made changes and created a PR. Please review.