repack icon indicating copy to clipboard operation
repack copied to clipboard

Published 20 hours ago • verified publisher icon callstack

fix: log errors before exit

Open hosseinmd opened this issue 1 year ago • 3 comments

Summary

To clarify what are errors exactly, we need to log them before exist.

Test plan

hosseinmd avatar Jan 30 '24 13:01 hosseinmd

🦋 Changeset detected

Latest commit: 9d1e0e6a30bfd6218ea740f7037f6f1ec2362bbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@callstack/repack Patch
testerapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 30 '24 13:01 changeset-bot[bot]

Hi @hosseinmd, thanks for your contribution!

Can you showcase an example of how this improves error reporting when bundling? Before and after would be ideal, thanks!

jbroma avatar Jan 30 '24 14:01 jbroma

Before adding this I didn't have any idea what is error this is my logs

Screenshot 2024-01-30 at 8 10 57 PM

after adding this

Screenshot 2024-01-30 at 8 14 24 PM

Now it is clear what is the exact error and where it is happened

hosseinmd avatar Jan 30 '24 16:01 hosseinmd

This pull request has been marked as stale because it has been inactive for 60 days. Please update this pull request or it will be automatically closed in 14 days.

github-actions[bot] avatar Mar 25 '24 00:03 github-actions[bot]

@hosseinmd thank you for your contribution! 🚀

jbroma avatar Apr 04 '24 16:04 jbroma