react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

Published 20 hours ago • verified publisher icon callstack

fix: remove deprecated use of defaultProps

Open timbocole opened this issue 1 year ago • 7 comments

Motivation

This PR prevents the error log warning the "defaultProps" will be removed (visible in RN0.74.0)

Related issue

Addresses #4382

Test plan

Ensure that use of the TextInputIcon does not produce the error (included in linked issue) when run using RN0.74.0

timbocole avatar Apr 26 '24 12:04 timbocole

Hey @timbocole, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

callstack-bot avatar Apr 26 '24 12:04 callstack-bot

LGTM, This will be on version 5.12.4

gedu avatar Apr 27 '24 17:04 gedu

Hi @gedu @sethimcclaine any Idea when is 5.12.4 scheduled for?

rodrigoAbril avatar May 15 '24 12:05 rodrigoAbril

Hi all!! Thanks for the work!. So I shall wait until the next release ? and ignore the error message? Thanks!!!!!

nickba86 avatar May 16 '24 10:05 nickba86

Hi @gedu @sethimcclaine any Idea when is 5.12.4 scheduled for?

Hey, we are trying to upgrade paper to support almost latest RN version, and after that we will submit it, I hope as soon as possible

gedu avatar May 17 '24 07:05 gedu

on RN 0.74.2 I get a warning with this problem.

nazaruha avatar Jun 07 '24 13:06 nazaruha

Is there any update with this PR?

josiahgerald avatar Jun 17 '24 12:06 josiahgerald

When it will be released to main?

itosinu avatar Jul 02 '24 11:07 itosinu

The main maintainer of the library has been really busy these past days. I would like him to perform a final check on all the open PRs that will be merged for Milestone 5.12.4. Hope it will be soon

gedu avatar Jul 02 '24 14:07 gedu

merge pleeease

AstronautJoe avatar Jul 09 '24 04:07 AstronautJoe

merge please :pray:

LuisDanilo avatar Jul 11 '24 23:07 LuisDanilo

Following the tradition of asking for a merge, could you please merge that one? 😆

Loschcode avatar Jul 12 '24 01:07 Loschcode

How do I follow this pull request to know when it gets merged?

jerrywonderr avatar Jul 12 '24 06:07 jerrywonderr

Why don't merge this PR? Many of people is waiting to be approved.

itosinu avatar Jul 17 '24 09:07 itosinu

Merge the change finally. This isn't a breaking change or something, there are no reasons to keep this for months.

h3d0 avatar Jul 19 '24 07:07 h3d0

Merge the change finally. This isn't a breaking change or something, there are no reasons to keep this for months.

No way. The code broke. Is this because of that change?

maiznadeem avatar Jul 28 '24 17:07 maiznadeem

This broke the update - https://github.com/callstack/react-native-paper/pull/4422/files

Also, there is a PR that will fix it - https://github.com/callstack/react-native-paper/pull/4466

Mostly will be available in the next release

raajnadar avatar Jul 28 '24 18:07 raajnadar

I was about to say, not sure how this PR could be at fault! 😂 - Thanks @raajnadar for the update/fix.

timbocole avatar Jul 28 '24 19:07 timbocole

This issue also affects version 4. What would be the best way to take this fix to that version as well?

mauricionuup avatar Aug 22 '24 22:08 mauricionuup