cake icon indicating copy to clipboard operation
cake copied to clipboard

Published 20 hours ago • verified publisher icon cake-build

GH4278: Update Spectre.Console to 0.48.0

Open devlead opened this issue 2 years ago • 3 comments

  • fixes #4278

devlead avatar Nov 24 '23 15:11 devlead

It would seem Spectre.Console 0.48.0 has a breaking change with settings like

https://github.com/cake-build/cake/blob/ed612029b92f5da2b6cbdfe295c62e6b99a2963d/src/Cake/Commands/DefaultCommandSettings.cs#L55-L57

This test fails

https://github.com/cake-build/cake/blob/ed612029b92f5da2b6cbdfe295c62e6b99a2963d/src/Cake.Tests/Unit/ProgramTests.cs#L101-L104

only the last --ver works.

image

not investigated the root cause fully.

devlead avatar Nov 24 '23 16:11 devlead

Found the issue Spectre.Console.Cli no longer allows default commands to have a --version parameter, which Cake relied on to have it's own custom version command.

https://github.com/spectreconsole/spectre.console/commit/131b37fff858f8d5dd483ff369bb3d43a07c1e08#diff-d38c9fa48d9c39f8eec58957b2333d13943f2cbe1adee26f30325e527a56f600L26-R41

Will see if I can find away around that, can't use the default Spectre version command as it will produce a version string that will break Cake cli contract. Overriding command settings ApplicationVersion and removing cake version feature should probably achieve the same result for end user.

devlead avatar Nov 24 '23 20:11 devlead

As it's by design breaking change in Spectre.Console.Cli, I just added a workaround to opt-out of this behavior for Cake.Tool.

devlead avatar Nov 24 '23 20:11 devlead