Cancai Cai comments

Results 180 comments of


                                            Cancai Cai

[CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior

It looks like there is a class loading conflict. Can anyone help me answer this question, I would be very grateful

[CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior

@tanclary It seems like I don't have a good way to solve this problem. Can you give me some advice?

[CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior

> Can you be more specific? What problem? Thank you for your reply. You can find that I defined ReturnTypes.DOUBLE_FORCE_NULLABLE in LOG10_MS. The purpose is to make LOG10_MS return null...

[CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior

@tanclary I feel that I cannot change SqlStdOperatorTable, which will affect some other tests (I tried)

[CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior

> No, the parser should not be making decisions about semantics. The validator (assisted by the operator table) should be doing that. Hi，thank you for your reply. I would like...

[CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior

@tanclary In addition, I have to explain that currently calcite's log10(0) returns -Infinity, but many databases I tested returned NULL or errors. I am not sure whether I should modify...

[CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior

I created two corresponding subtasks because the PR code changes may be large, and I am not sure about the ln and log10 functions, so I will adapt the log...

[CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType

I may need to add some comments, but the code structure is basically determined

[CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType

> Before I read`adjustTypeForMapFunctionConstructor`, I want to know why we need this method? If `MAP` function throw an exception when component type not equal? Like `map('k1', cast(1 as tinyint), 'k2',...

[CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType

Here you need to convert mapKeyType and mapValueType into the corresponding Biggest Type. According to the initial method, there is definitely no conversion of mapKeyType and mapValueType into the corresponding...