Kieran

Results 123 comments of Kieran

> @bytestream this packages uses class prefixes to avoid conflicts with other classes from other packages or project's classes. This is an approach used before 5.3.0, where namespaces where introduced....

This will be an environment / PHP configuration issue. Ensure ext-dom / ext-xml is correctly loaded, no configuration warnings, and a modern version of libxml2 is used.

@ezyang when do you expect a new release with php 7.2 support? It looks like PR's have already been merged for the issues I've noticed.

> Shouldn't you rather than use the splice() method? `unset` is marginally faster than `array_splice` on large arrays. It's also easier to work with, `array_splice` keeps reindexing so it's difficult...

Laravel sorts by length before doing the replacements - https://github.com/laravel/framework/blob/v7.0.0/src/Illuminate/Translation/Translator.php#L217

This can be closed :) https://github.com/sebastianfeldmann/phpbu-laravel/pull/10

Hey Jake! Thanks for doing some work on this. > It seems only the specific case of `` being a child of fails I think there were a few other...

> I think there were a few other nuisances identified. There's several reports in both Symfony and Roundcube which is why they added optionally parsing via masterminds/html5. I couldn't find...

To weigh in from the perspective of #828. I'm not sure how far you want to go with respect to decoupling DOMDocument usage... The biggest benefit of the `masterminds/html5` parser...

What changes do you propose upstream to achieve it? The spec seems to suggest both `disabled` and `disabled=""` are valid, the latter being backwards compatible with XHTML syntax. An option...