Jean Boussier

Results 329 comments of Jean Boussier

Ah, that rings a bell. 99% sure I fixed that bug not so long ago, let me look.

Alright, I'm bad at writing commit messages, so I can't be fully certain, but I think this was the fix: https://github.com/Shopify/memcached/commit/28b5840461f459986953660a3079f3547b1ce1d2 But overall you can use this branch, we use...

ROFL, I just assumed it was advocating for `block_given?`, I couldn't imagine `&block` would ever be faster. Same perf at best. So yeah, definite 👍

I'm seeing this one on `redis/redis-rb`: https://github.com/redis/redis-rb/actions/runs/7453547547/job/20279162533?pr=1245. No idea what to make of it.

Right, I saw 3 issues referencing the error, so I figured I wouldn't open an independent one. Thanks for the fix.

> (where they're never released, as far as I know). That's incorrect. "fstrings" (AKA interned strings) are garbage collectable.

> I've heard that it's an antipattern but I don't know why. AFAIK, it's mostly because that skip letting the GC know that some memory was freed, so GC might...

Fixed in https://github.com/rails/builder/pull/15

So part of this has been fixed in https://github.com/rails/rails/pull/50594, but the 7.1 backport ain't trivial.

Please cleanup the git history, but other than that 👍