html-to-image icon indicating copy to clipboard operation
html-to-image copied to clipboard

build: 📦️ fix build issue

Open withyousoft1983 opened this issue 3 years ago • 3 comments

Description

Motivation and Context

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Enhancement (changes that improvement of current feature or performance)
  • [ ] Refactoring (changes that neither fixes a bug nor adds a feature)
  • [ ] Test Case (changes that add missing tests or correct existing tests)
  • [ ] Code style optimization (changes that do not affect the meaning of the code)
  • [ ] Docs (changes that only update documentation)
  • [ ] Chore (changes that don't modify src or test files)

Self Check before Merge

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

withyousoft1983 avatar Aug 09 '22 11:08 withyousoft1983

👋 @withyousoft1983

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

biiibooo[bot] avatar Aug 09 '22 11:08 biiibooo[bot]

@withyousoft1983 Please provide us with more info about this pull request.

biiibooo[bot] avatar Aug 09 '22 11:08 biiibooo[bot]

This pull request fixes 1 alert when merging 2adb66bc527910cca4477ab92484ca58b73d190e into aaa0f6e6762c76c6669c13ed6a864c1f5d2e39e1 - view on LGTM.com

fixed alerts:

  • 1 for Polynomial regular expression used on uncontrolled data

lgtm-com[bot] avatar Aug 09 '22 12:08 lgtm-com[bot]

@withyousoft1983 push lib dir to repo is not necessary.

bubkoo avatar Jan 30 '23 07:01 bubkoo