browserpad icon indicating copy to clipboard operation
browserpad copied to clipboard

80 Column Mode Switch

Open LinuxinaBit opened this issue 1 year ago • 5 comments

I've set the default to 100% width because it should just be the default, and I've added simple JS checkbox logic to switch to 80 column if what you are editing requires this.

LinuxinaBit avatar Nov 03 '23 02:11 LinuxinaBit

@RageGamerBoi thanks for the PR! Could you please enable GitHub Pages in your fork, so that we could check the preview of these changes in https://ragegamerboi.github.io/browserpad?

waldyrious avatar Nov 12 '23 20:11 waldyrious

@RageGamerBoi thanks for the PR! Could you please enable GitHub Pages in your fork, so that we could check the preview of these changes in https://ragegamerboi.github.io/browserpad?

Should work now :)

LinuxinaBit avatar Nov 13 '23 14:11 LinuxinaBit

Just re-tested and text wrapping is weirdly broken (at least on IOS), I’ll see what I can do when I get home.

LinuxinaBit avatar Nov 13 '23 14:11 LinuxinaBit

It should be fixed now 🎉

LinuxinaBit avatar Nov 14 '23 16:11 LinuxinaBit

I could add a separate word wrapping checkbox, but I should probably do that in a different PR after this one is merged. I have fixed the line-wrapping guide jank however. It works much better now in every browser I tested (Safari on iPadOS, Chromium, and Firefox)

LinuxinaBit avatar Nov 15 '23 16:11 LinuxinaBit

Recently changed my GitHub username, the demo should be hosted here: https://linuxinabit.github.io/browserpad/ It’s working great as far as I can tell.

LinuxinaBit avatar Oct 11 '24 02:10 LinuxinaBit

So sorry for the long delay in review! :see_no_evil:

This looks great. Thanks for enabling the preview! There are some minor tweaks I would like to see, but none are deal-breakers and this seems like a strict improvement over the current situation, so I'll just go ahead and merge it :)

Thanks a bunch for the contribution!

waldyrious avatar Oct 22 '24 21:10 waldyrious