publicEncrypt

publicEncrypt copied to clipboard

fix for #7

NACK. As discussed in #7, this isn't our problem.

we've troubleshooted this two times already, even though this isn't our problem, I don't want to troubleshoot this a 3rd time or a 7th time.

Just leave the thread as a warning for others?

So eventually they will make it here, but they may open an issue several other places first before they get to here and find this. Yes it is 100% the users fault for accidentally including node_modules but we may be able to prevent those users from wasting a lot of other people's time as they try to figure out what the issue is.

It hasn't wasted that much time? The issue should be quite easily google-able now.

Is it possible to merge this and publish a package without the tests? I don't pack node_modules, it's just a disturbing warning during extension development in chrome when you load unpacked extension.

And besides of the chrome extension development issue, why do you need to pack tests into the production package?

@Ajnasz I totally agree with you. This has nothing to do with accidentally including node_modules into their chrome extension, but is just annoying during development. @dcousens Is there any suitable reason to not ship the test directory? Instead of having a long discussion about including node_modules into chrome extensions, we just could focus on the main problem and solve it...

Just ignore test/, NACK for these files only

Can we merge it to master ? It's against our security scan