cipher-base

cipher-base copied to clipboard

@calvinmetcalf can you check code before tests? It is not simply removing because I want strict following by node crypto. Is CipherBase/CipherivBase/.. good decision?

default encoding should be utf8 PR in hash-base: https://github.com/crypto-browserify/hash-base/pull/4

in node the cipher and cipheriv are based on each other so there isn't really much need for a separate.

Also some of these changes are things that probably seem clearer to you, but seam less clear to me and are probably overall exactly the same clarity wise. These add some needless churn to the diff so could you separate out the more stylistic changes from the functional ones so I can review them separately?

We should also probably update the default encoding in a sperate pull because that is probably what's hosing the tests.

(was on vacation last week, then got really sick wtihin hours of getting home this week so am still digging out)

Updated. Will actual when Node v0.12 will not be supported and when https://github.com/nodejs/node/pull/9405 / https://github.com/nodejs/node/pull/9398 will be merged.

@fanatid can you action this? Potentially merge https://github.com/crypto-browserify/cipher-base/pull/8 prior

@dcousens if I remember correctly this WIP because we decide wait until 0.12 will out of support? you free to change or create new PR based on this

OK, 0.12 has been dropped, 4 is the LTS now... so we can merge?

I think yes, but safe-buffer should be added and final word belongs to @calvinmetcalf