browser-pack icon indicating copy to clipboard operation
browser-pack copied to clipboard

Published 20 hours ago • verified publisher icon browserify

Add missing semi-colon when using source maps

Open qraynaud opened this issue 11 years ago • 5 comments

When minifying and concatenating files the missing trailing semi-colon can create side effects resulting in bugs.

qraynaud avatar Jul 31 '14 12:07 qraynaud

Ping! Running into this issue right now; this commit seems straightforward enough, but concerned that it doesn't look like it's gotten attention for over a year. See https://github.com/substack/node-browserify/issues/1351.

Would be happy to chip in to help get this (or another fix) merged.

henryptung avatar Aug 25 '15 08:08 henryptung

Ping?

henryptung avatar Sep 17 '15 16:09 henryptung

The commit is straightforward, but the consequences are not. Last time I looked at this, there were problems with the standalone option.

zertosh avatar Oct 07 '15 17:10 zertosh

@zertosh Can you provide a repro or description of the case you ran into? May be able to take a look if I have a place to start from. Thanks!

henryptung avatar Jan 14 '16 01:01 henryptung

umd.postlude(...) returns });, so when you use both sourcemaps and standalone, you end up with double ;

zertosh avatar Jan 18 '16 04:01 zertosh