Results 285 comments of Brian Scholer

> Small note on this pr, I have no clue how to fully and properly run the pytest tests. I'm constantly getting the error that there's a relative import that's...

> @briantist I finally had some spare time to put into this again. sorry for the insane long delay. I added some base tests for `_hashi_vault_common` I tried to trigger...

> * should i move the tests into a separate file? (I test another class, but it's in the same file so I assumed it should also go in the...

It might be good to start migrating plugins and modules to use this method. Could you do one plugin and one module and push those up so that I can...

> Not sure why this one failed on the CI - LI, but main is also failing (https://github.com/ansible-collections/community.hashi_vault/actions/runs/9528624007) yeah the local integration tests have been failing, nothing to do with...

@mathijswesterhof the devel failures are not related to this, that needs to be fixed separately for the repo. > I want to get started with the new ansible functions next...

The CI for the repo has been fixed, so let's get a new CI run after you update your branch

Hi @pfeifferj welcome! Thanks for looking to continue the work in #220 . First, I'd like to ensure that the commits in this branch that came from that PR still...

> I'll fix the commit attribution later today. Are you okay with the commits still being squashed to keep the history more readable, though? Yes squashing is fine. I think...

Hi @pfeifferj , I might be able to help resolve some of these conflicts and older rebase artifacts, but I noticed several pushes today so I don't want to push...