deprecation icon indicating copy to clipboard operation
deprecation copied to clipboard

do not require unittest2 when not neccessary

Open pgajdos opened this issue 5 years ago • 3 comments

One of possibilities how to live without unittest2.

pgajdos avatar Jun 01 '20 12:06 pgajdos

Codecov Report

Merging #50 into master will increase coverage by 1.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #50      +/-   ##
===========================================
+ Coverage   98.87%   100.00%   +1.12%     
===========================================
  Files           1         1              
  Lines          89        88       -1     
  Branches       18        18              
===========================================
  Hits           88        88              
+ Misses          1         0       -1     
Impacted Files Coverage Δ
deprecation.py 100.00% <100.00%> (+1.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a740a40...cc9d9ff. Read the comment docs.

codecov-commenter avatar Jun 01 '20 12:06 codecov-commenter

unittest2 is still always being imported because it's currently a part of test-requirements.txt. I think if you want this change to be fully effective we probably need to pull it out of test-requirements and then add testenvs in tox.ini for the versions that do need unittest2, that way the 2.7 tests run with unittest2 and the later 3.x run with regular unittest.

briancurtin avatar Jun 01 '20 13:06 briancurtin

Something like that? Not much familiar with tox, sorry.

pgajdos avatar Jul 16 '20 10:07 pgajdos