Divyansh Singh

Results 369 comments of Divyansh Singh

Also, the tests seem to be failing, please update those too.

No preference. You can just keep pushing things. No need to write in conventional commit format too. We do squash and merge, so it's the PR title that matters. Commit...

Use some terminal other than git bash / MINGW64

Ah, sorry. Slipped my notice. Looks good. I'll check the styles once maybe (grid-related styles aren't needed?) and merge it before next minor release. Also, can you rebase it to...

Try adding something like this to your `.vitepress/config` for now: (you can directly use something like patch-package or pnpm patch too instead of monkey patching like this) ```ts import {...

Not a bug technically, just an additional validation. I'll review your PR when I get some time.

Ah, we are trying to avoid adding new icons to the core because they can't be tree shaken and end up in the bundle for everyone (even if they aren't...

Please provide a reproducible example. It should work fine. Are there any errors on terminal during build or in devtools while previewing? What’s your directory structure and what’s the exact...