Brandon Roberts
Brandon Roberts
Sounds good to me. Would you like to put in a PR for this?
@jordanpowell88 @Stephenradams yep, that seems like a good place to me.
I'm on board with bringing over the tour of heroes app
I disagree with adding this as I think it muddies up the separation between selectors and the store
Thanks @Armenvardanyan95, I'm still planning to take this one
I'll be taking a look at this soon to improve the cleanup of instances when used with HMR
Check with @markostanimirovic to be sure he hasn't started it yet
Thanks Brian for the interesting use case. I'm of the opinion that instead of adding another way to create a selector, we should allow the instrumentation of an existing selector...
Oh ok, I see. There would need to be some tweaking on the types, tests, and docs to move it forward. My other question is an instrumented selector throwaway code...
If we add some type of configuration object, we could potentially use that to identify the selector, and provide a default for existing selectors. It would also allow some flexibility...