Craig Edwards (Brain)

Results 46 comments of Craig Edwards (Brain)

Hi and thanks! I'm already in the contributors list due to previous pull request 2199 on duktape: https://github.com/svaarala/duktape/pull/2199

~~I think something somewhere is being cached. I'm getting this behaviour with a self hosted instance, where I've put the zones into my bind instance used for the whole network....

After updating to newer cmake and also moving to develop branch, only the get_time() part of this merge is required there. This cuts down the patch significantly.

pretty sure we already have these? https://github.com/brainboxdotcc/DPP/blob/4b73548afae10d3c1a2089e045efde88632bd1da/include/dpp/channel.h#L57

there are no updates to the docs? they're just channels that can only contain threads

i dont see any need to change just the readme for this repository, other contributions are however welcome.

don't send audio inside the on buffer send, it is going to be near impossible to get the timing right. calling send audio raw does opus encoding and sodium encryption...

youre writing inside the write event, causing a recursion. the error is a stack overflow, its the way your code is written.

nlohmann and fmt are header only. it would be nicer if they weren't patched out, because we test with specific versions and not just whatever the latest is which could...

> I added DPP to [xmake](https://xmake.io) repository (see [xmake-io/xmake-repo#1222](https://github.com/xmake-io/xmake-repo/pull/1222)), with my changes it compiles fine on Windows, MinGW, Linux, macOS in both dynamic and static linking. > > Since xmake...