devcamper-api icon indicating copy to clipboard operation
devcamper-api copied to clipboard

Published 20 hours ago • verified publisher icon bradtraversy

allow user choose to use TOTP (Time-based one-time password)

Open rookiemonkey opened this issue 5 years ago • 3 comments

added support for TOTP instead of just a password but only if their email is confirmed

rookiemonkey avatar Aug 26 '20 06:08 rookiemonkey

Hey, this is an incredible feature but remember....Brad usually like to keep the improvements as close as possible to the original course content. @bradtraversy , do you mind checking on this? I believe this is a great feature and surely the students will love it also.

kirasiris avatar Dec 24 '20 17:12 kirasiris

, I actually did this about a month ago when Brad released his YouTube video. It would have been good of me to check this PR, I would have had it implemented in my app way long ago lol.

This is my version: https://gist.github.com/kirasiris/4326bf85d06b78c5e1de9f93c6e05d2a

kirasiris avatar Dec 24 '20 17:12 kirasiris

Hi @kirasiris I'm so sorry for responding so late XD. I'm so focused on my school projects this past days (not to mention celebrating holidays hahah!). I actually thought of it as well that brad might not consider this PR but thats ok because I only requested this PR to practice contributing to open source projects :). I actually had a look on your version and its way more awesome! by the way, Happy New Year! and stay safe always :)

rookiemonkey avatar Jan 04 '21 01:01 rookiemonkey