Bradley Ayers

Results 64 comments of Bradley Ayers

> So, does this there are no breaking changes then? "Breaking change" is a subjective term, so I think this boils down to being a judgment call. I'm happy to...

@SinghSukhdeep does `pkg.main` support having the file extension omitted?

Reverting the documentation changes would also require reverting the code changes that move `lib/traditional.js` to `lib/traditional/index.js`, else the docs won't match up with the file structure.

> To ensure we don't break backwards compatibility, can't we just keep the traditional.js, s3.js, etc files? Yeah I considered that, but I wasn't sure if the module resolution spec...

I'm assuming that for `package.json` to have effect the directory index needs to be used by TypeScript. I'll have a play with this and report back.

I've tested this and leaving the `.js` files in-place, and adding `package.json` in subdirectories seems to work. I'll update the PR to use this approach to minimise the changes.

@SinghSukhdeep I'm not actively working on it, but I am still using my FineUploader fork in production (it includes this change + using native promises), so I'm still invested in...

> Isn't there an extra | at the beginning or I'm not reading it right TypeScript has supported leading `|` for a while, see https://github.com/Microsoft/TypeScript/issues/12071. It was purely a stylistic...

I'm happy to take a stab at this one, I'll raise a PR and see what you think.