Maurice Parrish

Results 52 comments of Maurice Parrish

@TheVinhLuong I merged in the latest changes and it looks like the test stop failing. It may have been caused by a regression in the flutter/flutter repo. This PR should...

This is the aggregate PR still waiting on the implementations PR: https://github.com/flutter/packages/pull/5664

> @bparrishMines > > > @PROGrand This platform implementations contain different code than what is in #3586. Or at the very least, `camera_android` does? Is this intentioinal? > > Sure...

> The biggest problem I see with this is that this is a "lossy" fix; what you deserialize is _not_ what you were serializing; `"[Cyclic]"` might be good for the...

Looking at the issue and the Android output, it looks like Android basically just calls [String()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/String) on an object passed to the console. Android just returns `[object Object]` when passed...

@tarrinneal It looks like the scenario is a combination of: 1. Using a primitive enum as a method parameter or return value 2. Generates Objective-c code with a prefix It...

@tarrinneal Adding the prefix to core tests also found a location where the prefix wasn't added to the enum. I think a better solution might be to actually get rid...

Actually it looks like the problem is bigger than enums. Objective-c prefixes may need a bigger fix.

@yk3372 The dart formatter was most likely failing because you were using an older version of Flutter. We develop plugins on the latest version of the main branch of [flutter/flutter](https://github.com/flutter/flutter),...

I left a few more comments and updated the lint the Java code for the new lint warnings.