jackson icon indicating copy to clipboard operation
jackson copied to clipboard

Fix IdP initiated saml login

Open niwsa opened this issue 3 years ago • 1 comments

What does this PR do?

Fixes an issue where the token exchange failed in IdP initiated SAML login.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • [x] Existing unit tests

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code and corrected any misspellings
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

niwsa avatar Aug 12 '22 10:08 niwsa

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Aug 12 '22 10:08 ghost