s3transfer icon indicating copy to clipboard operation
s3transfer copied to clipboard

futures.TransferCoordinator: fix cancellation deadlock

Open tschoonj opened this issue 4 years ago • 2 comments
trafficstars

This patches fixes a deadlock whenever TransferManager._shutdown is called with cancel==True

tschoonj avatar Mar 08 '21 13:03 tschoonj

Codecov Report

Merging #179 (3da31a7) into develop (e862f6b) will decrease coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
- Coverage    97.79%   97.71%   -0.09%     
===========================================
  Files           15       15              
  Lines         2408     2404       -4     
===========================================
- Hits          2355     2349       -6     
- Misses          53       55       +2     
Impacted Files Coverage Δ
s3transfer/futures.py 95.05% <100.00%> (-0.08%) :arrow_down:
s3transfer/manager.py 97.53% <0.00%> (-0.99%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e862f6b...3da31a7. Read the comment docs.

codecov-io avatar Mar 09 '21 08:03 codecov-io

@kdaily could you give this one a look? And #144?

Thanks in advance!!

tschoonj avatar Mar 26 '21 14:03 tschoonj