Borek Bernard

Results 241 comments of Borek Bernard

@drupalista-br Could you point to unit tests covering all the tricky INI scenarios, similar to our [IniSerializerTest](https://github.com/versionpress/versionpress/blob/4fd75691e8d73712a1c1f7a6195c10fa17cb9596/plugins/versionpress/tests/Unit/IniSerializerTest.php)? Unless there's such test suite I don't trust the parser :)

Just a thought but maybe we could use a `.vp` file extension; I dislike mentioning INI in the documentation :)

@ustun TOML seems nice, thanks for the pointer. In practice, it's a bit problematic adopting any niche language and we already switched once (NEON -> YAML, https://github.com/versionpress/versionpress/issues/703), but it's always...

Just going to say here that I encountered TOML in some React-related projects, read up a little bit on it (e.g., [this discussion](https://github.com/toml-lang/toml/issues/411) on whether to make it fully compatible...

Brilliantly described, thank you! I'm inclined to think that the warning would indeed be useful here, would you mind sending a PR?

> We should probably also change "Non-admin action" to something else, for example "Anonymous action"? Agreed. It currently looks like this in a Git commit: ``` Author: Non-admin action ```...

I like the "VersionPress" suggestion, this is how it would look: ``` Author: VersionPress ``` What do you think? BTW, are you comfortable enough trying to update the front-end as...

Hi @emaildano, I don't think two slashes are normal, is that possibly something about your WP configuration?

Hi @ben-caplan, thanks for the PR. We've looked into this closer with @JanVoracek today and it turns out that it won't be that simple. For reference, the logging is added...

> Would the idea then be to remove the use of `idMapContainsAllVpIds` in addition to allowing/forcing the double loop (by removing the true/false nature of `fixMnReferences`)? Yes, that would be...