test icon indicating copy to clipboard operation
test copied to clipboard

Published 20 hours ago • verified publisher icon boostorg

Allow per-element comparison of string against non-string iterable

Open ecatmur opened this issue 5 years ago • 5 comments

(of char).

Test.

ecatmur avatar Dec 16 '19 10:12 ecatmur

This is being superseded by the branch topic/PR-187-BOOST_TEST-with-tolerance-message. It would be nice if you can give a try to see if this addresses your needs.

@ecatmur

raffienficiaud avatar Apr 08 '20 14:04 raffienficiaud

@raffienficiaud thanks, I've tested and I still need the change for comparisons to work. I've rebased my patch and force pushed.

My commit is the last one, https://github.com/boostorg/test/pull/242/commits/50826175f8fd19e94fb85ac4db3de31fed3f74a0

ecatmur avatar Apr 08 '20 16:04 ecatmur

@ecatmur thank you for the quick feedback. I commented on the PR, I can give a spin on my CI, travis takes ages.

raffienficiaud avatar Apr 08 '20 17:04 raffienficiaud

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@7371c5c). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head 2648a1b differs from pull request most recent head 2d4d5c3. Consider uploading reports for the commit 2d4d5c3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop     #242   +/-   ##
==========================================
  Coverage           ?   55.77%           
==========================================
  Files              ?      112           
  Lines              ?     5897           
  Branches           ?     2382           
==========================================
  Hits               ?     3289           
  Misses             ?      778           
  Partials           ?     1830

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 27 '23 18:06 codecov[bot]

Chiming in here-- I'm sad to report that @ecatmur has passed away over the new-years holiday period. Commemoration / memorial / donate to good cause page in case interested.

This patch while in place at my organization, seemingly breaks compilation of some tests in Boost.MySQL as in Boost 1.85.0. Presumably due to some dependence on the new Boost.Charconv.

To be perfectly honest with you, I didn't bother figuring out the compile error, I tested against our tests internally and the heavy hitters where I would have expected a problem all compiled and passed / expected failed in the right places; so internally we're just going to undo the patch and if someone was relying on it tell them to convert their container to a string or similar course of action; it's not as if such unit tests are performance critical and can't afford the copy or anything.

Felt necessary to comment in case this would have gotten merged unknowingly.

13steinj avatar Apr 19 '24 05:04 13steinj