im-rs icon indicating copy to clipboard operation
im-rs copied to clipboard

implement `Clone` for iterator types

Open mikeyhew opened this issue 5 years ago • 3 comments

std::vec::Iter<'a, T> implements Clone, but it seems that im::vector::Iter<'a, T> does not. Would it be possible to to implement Clone for all of the by-reference Iter types in im, and would you accept a PR adding the impls?

mikeyhew avatar May 28 '20 23:05 mikeyhew

Absolutely. There's no good reason why they shouldn't implement Clone.

bodil avatar May 30 '20 12:05 bodil

I've hit the need of them just today. @mikeyhew are you working on the PR, or should I try to find a bit of time to give them a try?

vorner avatar Nov 03 '20 08:11 vorner

@vorner I'm not working on a PR for this, all yours!

mikeyhew avatar Nov 03 '20 21:11 mikeyhew