gobenchdata icon indicating copy to clipboard operation
gobenchdata copied to clipboard

Add CircleCI GoBenchData Orb (WIP)

Open bonedaddy opened this issue 5 years ago β€’ 4 comments

Overview

Opening this up to get some initial feedback. The idea behind this orb is to enable a CircleCI equivalent of the GitHub Actions capabilities of gobenchdata.

Changes

  • Adds a CircleCI orb
  • Currently published under rtradeltd/gobenchdata
  • Current capabilities:
    • Run benchmarks
    • Parse benchmark samples and generate data for gobencdata

TODO

  • ~Enable checks~
  • ~Enable uploading new benchmark data to specified branch~
  • Add example

bonedaddy avatar Jun 09 '20 22:06 bonedaddy

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   30.03%   30.03%           
=======================================
  Files           8        8           
  Lines         473      473           
=======================================
  Hits          142      142           
  Misses        315      315           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update a3b33d2...bece5cb. Read the comment docs.

codecov[bot] avatar Jun 09 '20 22:06 codecov[bot]

No I haven't, I will take a look at the entrypoint script though, thanks!

edit:

I think it will be possible to mirror the entrypoint.sh script you have. Should have a fully functional CircleCI orb within the next few days.

bonedaddy avatar Jun 10 '20 02:06 bonedaddy

Alright I've got feature parity with how the github actions behave. One question, the pr checks capabilities, does it cause PR CI builds to fail?.

edit:

Now that there's basic parity in place, i'll try to use the entrypoint.sh script. I'm not sure if it will be entirely possible though, given that some of the EnvVars it expects seem github action specific

bonedaddy avatar Jun 11 '20 06:06 bonedaddy

Now that there's basic parity in place, i'll try to use the entrypoint.sh script. I'm not sure if it will be entirely possible though, given that some of the EnvVars it expects seem github action specific

You could do some renaming to make the env vars match up - the only specific ones are GITHUB_, and they could be exported in the orb as REPOSITORY -> GITHUB_REPOSITORY for example.

I imagine CircleCI exports similar variables during CI runs!

bobheadxi avatar Jun 14 '20 01:06 bobheadxi