criterion-compare-action icon indicating copy to clipboard operation
criterion-compare-action copied to clipboard

Not working on GitHub enterprise

Open lcmgh opened this issue 3 years ago • 7 comments

(Use node --trace-deprecation ... to show where the warning was created) Warning: Failed to comment: HttpError: request to https://mycompany/api/v3/repos/myorg/myrepo/issues/9/comments failed, reason: tunneling socket could not be established, statusCode=503 Commenting is not possible from forks. ┌─────────┬────────────────────────────┬─

- uses: boa-dev/criterion-compare-action@6fdd4e866a4d4539e126afc158249a7631cc842e
  with:
    benchName: "my_benchmark"
    # Needed. The name of the branch to compare with. This default uses the branch which is being pulled against
    branchName: ${{ github.base_ref }}
    # Optional. Default is `${{ github.token }}`.
    token: ${{ secrets.GITHUB_TOKEN }}

lcmgh avatar May 23 '22 14:05 lcmgh

Which version of GitHub Enterprise is this? We now use Node 16, which might not be available in all GitHub Enterprise versions.

Razican avatar May 29 '22 07:05 Razican

The benchmark itself run through fine. What I am getting in the end is:

Warning: Failed to comment: HttpError: request to https://my-enterprise.com/api/v3/repos/myorg/my-service/issues//comments failed, reason: tunneling socket could not be established, statusCode=503
Commenting is not possible from forks.

GitHub Enterprise Server 3.4.3

lcmgh avatar Jul 07 '22 15:07 lcmgh

The benchmark itself run through fine. What I am getting in the end is:


Warning: Failed to comment: HttpError: request to https://my-enterprise.com/api/v3/repos/myorg/my-service/issues//comments failed, reason: tunneling socket could not be established, statusCode=503

Commenting is not possible from forks.

GitHub Enterprise Server 3.4.3

Hmm is the PR coming from a fork, instead of a branch in the same repo?

Razican avatar Jul 07 '22 17:07 Razican

The log from the previous comment came indeed from a branch triggered build and not from a PR, sorry for that.

I have now triggered the action from a pull request and it says

(node:745370) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Warning: Failed to comment: HttpError: request to https://my-company.com/api/v3/repos/myorg/myproject/issues/15/comments failed, reason: tunneling socket could not be established, statusCode=503
Commenting is not possible from forks.
┌─────────┬────────────────────────────

The URL of my PR is https://my-company.com/myorg/myproject/pull/15

The runner has appropriate proxy settings (HTTP_PROXY, HTTPS_PROXY, NO_PROXY) in place to use a proxy for intranet-internet connections and none for internal connections (such as the GitHub enterprise it is connected to).

lcmgh avatar Jul 08 '22 07:07 lcmgh

Note that GitHub doesn't allow writing comments from forks. This is a known limitation in GitHub, and there is nothing that can be done about it, unfortunately :(

Razican avatar Jul 09 '22 14:07 Razican

Actually the PR comes from the same repository.

lcmgh avatar Jul 11 '22 14:07 lcmgh