osrsclient icon indicating copy to clipboard operation
osrsclient copied to clipboard

New OS-JR Impl.

Open zeruth opened this issue 7 years ago • 4 comments

This uses netbeans! lol

So I have done a lot of work on OS-JR. I re-purposed it to be a library. It has gone from ~300 hooks in the first pull request to 1344. It has every hook Runelite does.

The implementation is explained via comments in "New OS-JR Impl." Accessed via getters in Hooks.selector after RSGame.run. ex: int loginstate = Hooks.selector.client.getLoginState();

The full list of Hooks is dumped every update to: https://github.com/zeruth/OSJR/blob/master/Hooks.txt

And YES! Everything in that list is accessible.

zeruth avatar Dec 20 '17 18:12 zeruth

Thanks for this. Currently doing some review of this in preparation for merge.

Can you explain a bit in here how the hooks are updated? Also, JSYK the link in your post gives me a 404.

bmoyer avatar Jan 14 '18 19:01 bmoyer

For a third party client to OSJR, copy the Hooks.json to your project.

The hooks are populated from rune-lite, whenever a gamepack revision change occurs.

zeruth avatar Jan 17 '18 04:01 zeruth

Been looking through this more, @zeruth. Would you be able to set things up so that OS-JR is instead compiled from source, rather than adding the jar file itself? I'd be fine just adding a directory to hold the OS-JR source in this repo to compile from.

Mostly looking into this for security reasons. I think the community would be more open to trying a new client if anything like that was compiled by the user (or a trusted third party).

bmoyer avatar Feb 03 '18 06:02 bmoyer

The jar is provided really only for convenience. And all it's source code is packed into it.

The intention is for people to fork my repo, Compile the source. Export the project as their own jar.

The JAR itself is not necessary to use osjr, but anyone can build the JAR and I recommend they do so. You could just take my source code and apply it directly, but osjr was designed as a sort of plugin, to separate game accessing from the client, as game accessing is rather fixed.

OSJR is currently in the middle of a big patch at the moment.

zeruth avatar Feb 05 '18 07:02 zeruth