node-oom-heapdump icon indicating copy to clipboard operation
node-oom-heapdump copied to clipboard

Prebuilt binaries failing for Node 22 on Windows

Open paulrutter opened this issue 1 year ago • 8 comments

See https://github.com/blueconic/node-oom-heapdump/actions/runs/8830424770

@spmiller when you have time, could you check why node 22 doesn't work?

paulrutter avatar Apr 25 '24 09:04 paulrutter

Hi @paulrutter , I'm away on holiday this week but should be able to take a look first thing next week. It looks like the Windows build can't find npm?!

spmiller avatar Apr 25 '24 10:04 spmiller

Great! No hurry. Yes, somehow npm cannot be found with 22.x

paulrutter avatar Apr 25 '24 11:04 paulrutter

Hi @paulrutter, it's lucky that "first thing next week" turned into Thursday because there is an upstream issue that has had some patches pushed recently: https://github.com/nodejs/node/issues/52682

By the time you read this they may have cut a new NodeJS release, but I would suggest that we can't build with Node 22 on Windows until the linked issue is resolved.

Good thing Node 22 isn't LTS eh!

spmiller avatar May 02 '24 02:05 spmiller

Then we can wait for that to be merged!

paulrutter avatar May 02 '24 05:05 paulrutter

22.1 seems to have fixed it :) thanks for checking it out @spmiller

See https://github.com/blueconic/node-oom-heapdump/commit/e36551dbd5401047480b248bd64bd82f4881fe9c

paulrutter avatar May 02 '24 17:05 paulrutter

A compilation failure now, i can look into this

paulrutter avatar May 02 '24 17:05 paulrutter

https://github.com/nodejs/nan/issues/968

paulrutter avatar May 03 '24 08:05 paulrutter

https://github.com/blueconic/node-oom-heapdump/actions/runs/9102048245

paulrutter avatar May 15 '24 20:05 paulrutter

https://github.com/blueconic/node-oom-heapdump/releases/tag/3.2.3

paulrutter avatar May 16 '24 07:05 paulrutter