deconfounder_public icon indicating copy to clipboard operation
deconfounder_public copied to clipboard

Published 20 hours ago • verified publisher icon blei-lab

Please consider fixing tensorflow imports

Open NeilGirdhar opened this issue 5 years ago • 2 comments

Thank you very much for uploading this. Would it be possible to get it working? Currently, tensorflow does not have a tf.contrib. And most tensorflow imports should be replaced with tensorflow.compat.v1. I'm going to start porting the movies problem to JAX.

Thanks for any help!

NeilGirdhar avatar Jul 28 '20 03:07 NeilGirdhar

Thanks for writing! I think the code should run out of the box if you use python 2, tensorflow 1.5.0, and edward 1.3.5. With these (old) versions of the packages, we will not need to change the imports to tensorflow.compat.v1 or tf.contrib.

yixinwang avatar Jul 28 '20 03:07 yixinwang

Thank you for the fast reply!

I intend to compare your results with a custom implementation on the same data. That means I need to get it working in modern Python. (Python 2 is dead, and most importantly JAX doesn't support it.) I will let you know if I have any other problems porting.

NeilGirdhar avatar Jul 28 '20 03:07 NeilGirdhar