server

server copied to clipboard

🎟️ Tracking

https://github.com/bitwarden/clients/pull/9845

📔 Objective

This PR is being made with consideration to the scope of behavioral changes within https://github.com/bitwarden/clients/pull/8431

We want to ensure that the inline menu positioning enhancement can be reversed in the case of unexpected issues when deployed.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

Jun 26 '24 17:06 cagonzalezcs

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.52%. Comparing base (25dc0c9) to head (6bad778).

@@           Coverage Diff           @@
##             main    #4387   +/-   ##
=======================================
  Coverage   41.52%   41.52%           
=======================================
  Files        1268     1268           
  Lines       60023    60023           
  Branches     5492     5492           
=======================================
  Hits        24925    24925           
  Misses      33948    33948           
  Partials     1150     1150           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jun 26 '24 17:06 codecov[bot]

Checkmarx One – Scan Summary & Details – 56bf38c8-6aa5-4635-b6a2-05d507f49d84

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	CSRF	/src/Api/AdminConsole/Controllers/GroupsController.cs: 122	Attack Vector
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 110	Attack Vector
	CSRF	/src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 133	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/Public/Controllers/CollectionsController.cs: 87
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 358
	CSRF	/src/Api/Controllers/CollectionsController.cs: 143
	CSRF	/src/Api/Controllers/CollectionsController.cs: 171
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 98
	CSRF	/bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 88
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 148
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 222
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 174
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 222
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 583
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 583
	Privacy_Violation	/src/Api/Vault/Models/Request/CipherRequestModel.cs: 198
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 628
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 607
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 657
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 583
	Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 174

Jun 26 '24 18:06 github-actions[bot]