server icon indicating copy to clipboard operation
server copied to clipboard

PM-1688 | individual vault encryption: remove client version restriction

Open merissaacosta opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-1688

📔 Objective

We are ready to remove the server restriction code for individual vault encryption since it has been more than 3 releases, in order to follow our versioning support plan: Versioning | Support .

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

merissaacosta avatar Jun 17 '24 21:06 merissaacosta

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.62%. Comparing base (1b5f9e3) to head (7897205).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4198   +/-   ##
=======================================
  Coverage   41.61%   41.62%           
=======================================
  Files        1269     1269           
  Lines       60140    60129   -11     
  Branches     5516     5515    -1     
=======================================
- Hits        25028    25027    -1     
+ Misses      33948    33938   -10     
  Partials     1164     1164           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 17 '24 21:06 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 17153bce-6648-4280-addf-571f8b1e8eba

No New Or Fixed Issues Found

github-actions[bot] avatar Jun 17 '24 22:06 github-actions[bot]