server icon indicating copy to clipboard operation
server copied to clipboard

[AC-2766] famlies sponsorship upcoming invoice email

Open cturnbull-bitwarden opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/AC-2766

📔 Objective

When validation fails for a sponsored families organization in the invoice.upcoming Stripe event handler, we update the families organization to the regular plan and update the subscription. This PR updates the invoice variable in the webhook so that it sends the correct email information.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

cturnbull-bitwarden avatar Jun 13 '24 17:06 cturnbull-bitwarden

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 40.60%. Comparing base (2841c1a) to head (1e9dcc4).

Files Patch % Lines
src/Billing/Controllers/StripeController.cs 0.00% 8 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4181      +/-   ##
==========================================
- Coverage   40.60%   40.60%   -0.01%     
==========================================
  Files        1232     1232              
  Lines       59518    59525       +7     
  Branches     5470     5471       +1     
==========================================
  Hits        24170    24170              
- Misses      34208    34215       +7     
  Partials     1140     1140              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 13 '24 17:06 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 8dffd1fd-3208-4b15-809f-345bef9ecf9c

No New Or Fixed Issues Found

github-actions[bot] avatar Jun 13 '24 17:06 github-actions[bot]