server icon indicating copy to clipboard operation
server copied to clipboard

[PM-8732] Add new launch configuration for SSO

Open trmartin4 opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-8732

📔 Objective

We currently have a launch configuration in VS Code that includes Admin, Identity, and API. On the Auth team (and potentially others as well), we often have the need to configure SSO as well in order to test certain features (e.g. TDE). This change adds a new launch configuration that includes Admin, Identity, API, and SSO.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

trmartin4 avatar Jun 08 '24 21:06 trmartin4

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.79%. Comparing base (e5c77d5) to head (cdde050). Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4168   +/-   ##
=======================================
  Coverage   41.79%   41.79%           
=======================================
  Files        1308     1308           
  Lines       62051    62051           
  Branches     5716     5716           
=======================================
  Hits        25936    25936           
  Misses      34921    34921           
  Partials     1194     1194           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 08 '24 22:06 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 15780574-645a-4b45-b90c-210dd73ef658

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 580
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 217
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 217
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 247
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 171
MEDIUM CSRF /src/Api/Public/Controllers/CollectionsController.cs: 87
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 170
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 366
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 155
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 155
MEDIUM CSRF /src/Api/Controllers/SettingsController.cs: 36
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 507
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 480
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 140
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 209
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 295
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 189
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 882
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 246
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 221
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 261
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 196
MEDIUM CSRF /src/Identity/Controllers/SsoController.cs: 143
MEDIUM CSRF /src/Identity/Controllers/SsoController.cs: 102
MEDIUM CSRF /src/Identity/Controllers/SsoController.cs: 41
MEDIUM CSRF /src/Identity/Controllers/AccountsController.cs: 75
MEDIUM CSRF /src/Icons/Controllers/IconsController.cs: 53
MEDIUM CSRF /src/Events/Controllers/CollectController.cs: 38
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 48
MEDIUM CSRF /src/Billing/Controllers/FreshsalesController.cs: 49
MEDIUM CSRF /src/Billing/Controllers/FreshdeskController.cs: 44
MEDIUM CSRF /src/Billing/Controllers/BitPayController.cs: 51
MEDIUM CSRF /src/Api/Vault/Controllers/SyncController.cs: 59
MEDIUM CSRF /src/Api/Vault/Controllers/FoldersController.cs: 79
MEDIUM CSRF /src/Api/Vault/Controllers/FoldersController.cs: 64
MEDIUM CSRF /src/Api/Vault/Controllers/FoldersController.cs: 54
MEDIUM CSRF /src/Api/Vault/Controllers/FoldersController.cs: 45
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 189
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 140
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 121
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 107
MEDIUM CSRF /src/Api/Tools/Controllers/SendsController.cs: 193
MEDIUM CSRF /src/Api/Tools/Controllers/SendsController.cs: 157
MEDIUM CSRF /src/Api/Tools/Controllers/SendsController.cs: 148
MEDIUM CSRF /src/Api/Tools/Controllers/ImportCiphersController.cs: 64
MEDIUM CSRF /src/Api/Tools/Controllers/ImportCiphersController.cs: 48
MEDIUM CSRF /src/Api/Tools/Controllers/HibpController.cs: 43
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ServiceAccountsController.cs: 156
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ServiceAccountsController.cs: 110
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsManagerPortingController.cs: 58
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsManagerPortingController.cs: 38
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 214
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 96
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 140
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 112
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 69
MEDIUM CSRF /src/Api/SecretsManager/Controllers/ProjectsController.cs: 51
MEDIUM CSRF /src/Api/SecretsManager/Controllers/CountsController.cs: 37
MEDIUM CSRF /src/Api/SecretsManager/Controllers/AccessPoliciesController.cs: 266
MEDIUM CSRF /src/Api/SecretsManager/Controllers/AccessPoliciesController.cs: 232
MEDIUM CSRF /src/Api/Public/Controllers/CollectionsController.cs: 64
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationSponsorshipsController.cs: 52
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationSponsorshipsController.cs: 42
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 71
MEDIUM CSRF /src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 51
MEDIUM CSRF /src/Api/Controllers/UsersController.cs: 22
MEDIUM CSRF /src/Api/Controllers/PushController.cs: 38
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 201
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 93
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 82
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 74
MEDIUM CSRF /src/Api/Controllers/DevicesController.cs: 61
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 247
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 233
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 171
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 128
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 119
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 99
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 61
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 143
MEDIUM CSRF /src/Api/Billing/Controllers/OrganizationSponsorshipsController.cs: 68
MEDIUM CSRF /src/Api/Auth/Controllers/WebAuthnController.cs: 153
MEDIUM CSRF /src/Api/Auth/Controllers/WebAuthnController.cs: 101
MEDIUM CSRF /src/Api/Auth/Controllers/WebAuthnController.cs: 59
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 102
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 95
MEDIUM CSRF /src/Api/Auth/Controllers/EmergencyAccessController.cs: 81
MEDIUM CSRF /src/Api/Auth/Controllers/AuthRequestsController.cs: 37
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 691
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 673
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 646
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 541
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 507
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 454
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 69
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 49
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 98
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 74
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 110
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 92
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/GroupsController.cs: 49
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 188
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 175
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 156
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 142
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 126
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 114
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 89
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 75
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderUsersController.cs: 62
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 121
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 54
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 73
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 61
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProviderOrganizationsController.cs: 48
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 148
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 78
MEDIUM CSRF /src/Api/AdminConsole/Controllers/PoliciesController.cs: 61
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationDomainController.cs: 75
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/ProviderOrganizationsController.cs: 35
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 351
MEDIUM CSRF /bitwarden_license/src/Sso/Controllers/AccountController.cs: 240
MEDIUM CSRF /bitwarden_license/src/Sso/Controllers/AccountController.cs: 167
MEDIUM CSRF /bitwarden_license/src/Sso/Controllers/AccountController.cs: 100
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/UsersController.cs: 50
MEDIUM CSRF /bitwarden_license/src/Scim/Controllers/v2/GroupsController.cs: 79
MEDIUM CSRF /src/Api/Auth/Controllers/TwoFactorController.cs: 118
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 171
MEDIUM CSRF /src/Api/Public/Controllers/CollectionsController.cs: 87
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 553
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 574
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 603
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 574
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 553
MEDIUM CSRF /src/Api/SecretsManager/Controllers/CountsController.cs: 37
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 366
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 882
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 176
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 574
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 574
MEDIUM CSRF /src/Api/SecretsManager/Controllers/SecretsController.cs: 96
MEDIUM CSRF /src/Api/SecretsManager/Controllers/AccessPoliciesController.cs: 266
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 98
MEDIUM CSRF /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 553
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 553
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 121
MEDIUM CSRF

More results are available on AST platform

github-actions[bot] avatar Jun 08 '24 22:06 github-actions[bot]