davx5-ose icon indicating copy to clipboard operation
davx5-ose copied to clipboard
verified publisher icon bitfireAT

Use `DAV:owner` for "Show only personal"

Open ArnyminerZ opened this issue 11 months ago • 3 comments

Purpose

Check whether "Show only personal" can use DAV:owner instead of "belongs to a homeset that belongs to the user".

Check especially with eGroupware. We had found the current solution with the homesets when we tested DAVx5 with eGroupware admin accounts, which would have many entries without such an option.

However at that time DAVx⁵ didn't query the DAV:owner, and now it does.

Short description

  • homeset.personal is now null by default.
  • When updating the homeset after refreshing collections, if the owner of the collection (in that case homeset) is the same as the service principal, it means that the collection is personal.

Checklist

  • [x] The PR has a proper title, description and label.
  • [x] I have self-reviewed the PR.
  • [x] I have added documentation to complex functions and functions that can be used by other modules.
  • [x] I have added reasonable tests or consciously decided to not add tests.

ArnyminerZ avatar Apr 30 '25 08:04 ArnyminerZ

Setting to "ready to review" because the four checkboxes in the description are checked :)

rfc2822 avatar May 15 '25 15:05 rfc2822

Purpose

Check whether "Show only personal" can use DAV:owner instead of "belongs to a homeset that belongs to the user".

Check especially with eGroupware. We had found the current solution with the homesets when we tested DAVx5 with eGroupware admin accounts, which would have many entries without such an option.

However at that time DAVx⁵ didn't query the DAV:owner, and now it does.

So, did we check with eGroupware?

sunkup avatar May 22 '25 12:05 sunkup

Btw, we should update the manual here

ArnyminerZ avatar Jun 04 '25 16:06 ArnyminerZ

I wonder whether we should really hack this into the existing DavResourceFinder / CollectionListRefresher or whether we should do another refactoring round of service detection before.

What do you think @ArnyminerZ @sunkup?

I am not sure what to change then or how to make it easier to understand. I think we can leave most as is for now and add the change.

sunkup avatar Jul 01 '25 09:07 sunkup

Okay, it took a while to properly understand everything. But I'm pretty sure that now i it's correct.

ArnyminerZ avatar Jul 04 '25 09:07 ArnyminerZ

The code became so complicated that I can't follow it anymore. So we have to split it first and then we can refactor it / add DAV:owner support.

So I'll close this PR and we should open a new one when #1588 is done.

rfc2822 avatar Jul 16 '25 15:07 rfc2822

So I'll close this PR and we should open a new one when #1588 is done.

Right. Probably better. Sorry for my misjudgement.

sunkup avatar Jul 17 '25 07:07 sunkup