atom-sublime-select

atom-sublime-select copied to clipboard

1. The arrow should turn into a "+" icon when I hold alt
2. I can't actually select anything because the text jumps around:

Here's the expected behavior (using LightPaper):

I'm using Atom version 0.113.0, and Sublime Style Column Selection 1.1.0.

Probably need to do this: https://github.com/Zren/atom-sublime-select/blob/master/lib/sublime-select.coffee#L45-L47 as I didn't get any jumping after that commit. Basically you need the:

+ editorView.scrollLeft()

It might also be to me copy+pasting the selection code from atom itself.

I think that was an issue with that version of Atom. I had that issue for a while but it seemed to have disappeared with the latest release.

Do you still have the issue after updating atom?

@Zren Nice fork! Any pull requests you wanna share?

My fork only binds the Middle mouse button to the cursor. I copy pasta'd the selection code from atom's source. I still have to run through it's performance though.

One thing I might PR is how you require the emissary dependency. It should be already loaded & cached by atom, and loading another instance for each package is silly. I've been forking a few packages to increase their load/activation times.

I'm doing

{Subscriber} = require atom.packages.resourcePath + '/node_modules/emissary'

and it seems to work.

It also drops load times from 47ms to 16ms.

This pattern isn't widespread however. Probably because it might break things atom changes around.

Updating to Atom 0.115 resolved the jumpy selection issue for me. However, the arrow should turn into a "+" icon when I hold alt, and it doesn't, so I'm leaving this issue open for now.

Yeah, I don't claim to be mimicking lightpaper. Its a good feature request tho

I got a fix for "The arrow should turn into a "+" icon when I hold alt" in #71. Please take a look. Ideas are welcome.