biemond-oradb icon indicating copy to clipboard operation
biemond-oradb copied to clipboard

Published 20 hours ago • verified publisher icon biemond

get_database_user method will always return 'oracle'

Open mschuchard opened this issue 7 years ago • 2 comments

At https://github.com/biemond/biemond-oradb/blob/649ee9c441ca100b8c1edf032e17fe54b3a065ae/lib/facter/oracle_database_homes.rb#L6 the value for databaseUser will always be nil because there is no override_database_user fact. Therefore, that method will always return 'oracle' and the facts and functions which rely upon it for correct behavior will be erroneous.

mschuchard avatar Sep 18 '18 13:09 mschuchard

Hi,

what do you mean? default oracle is used as OS user unless you set this fact override_database_user. It works for me.

thanks

biemond avatar Sep 25 '18 18:09 biemond

That usage is undocumented and makes assumptions about Facter resolution ordering which are not guaranteed.

mschuchard avatar Sep 26 '18 12:09 mschuchard