bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

Impmentation and basic unit tests for HEDVersion with libraries

Open VisLab opened this issue 3 years ago • 1 comments

This PR implements the bids-validator side of HED library support and is related to:

The relevant unit tests run with the draft hed-javascript version represented by hed-javascript PR#75.

Once this version has been released on npm, the package lock for the bids-validator will need to be updated, and all of the bids PRs can go forward.

In the meantime, @sappelhoff and @rwblair would you mind looking over and let us know if you spot any issues?

@happy5214 could you also check that I included everything we discussed?

VisLab avatar Aug 04 '22 13:08 VisLab

@VisLab @happy5214 This looks great. Node test errors will need to be resolved which should happen with hed validator release, but conceptually I think its solid.

rwblair avatar Aug 09 '22 17:08 rwblair

Codecov Report

Merging #1496 (f830f7a) into master (ee7d94c) will increase coverage by 0.01%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   83.36%   83.37%   +0.01%     
==========================================
  Files          91       91              
  Lines        3691     3688       -3     
  Branches     1123     1122       -1     
==========================================
- Hits         3077     3075       -2     
+ Misses        518      517       -1     
  Partials       96       96              
Impacted Files Coverage Δ
bids-validator/validators/events/hed.js 91.07% <85.71%> (+1.24%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 29 '22 17:08 codecov[bot]

Thanks @VisLab et al. :rocket:

sappelhoff avatar Aug 31 '22 08:08 sappelhoff

Note: I added a fix in https://github.com/bids-standard/bids-validator/commit/c344e2746611056a56778b0c19b584cace55b660

HEDVersion had not been updated in the JSON schema (done now, including the regexp).

sappelhoff avatar Aug 31 '22 09:08 sappelhoff