bids-validator icon indicating copy to clipboard operation
bids-validator copied to clipboard

Warning when gzip headers contain non-BIDS filenames

Open nellh opened this issue 3 years ago • 4 comments

The original filename might contain identifiable information if NIfTI files are compressed prior to being renamed. We should detect this and raise a warning if the header doesn't match the current filename.

nellh avatar Jan 05 '22 00:01 nellh

Note https://github.com/bids-standard/bids-specification/pull/1349 proposes making an error (I'm pushing for warning) for any value in the original filename. Also a non-zero timestamp.

effigies avatar Nov 04 '22 20:11 effigies

Yes, isn't it simpler if the headers simply aren't there? BIDS already specifies a fairly strict format of filenames, there's no need for that data to be duplicated in the gzip header.

Particularly I have the rationales in https://reproducible-builds.org/docs/build-path/ and https://reproducible-builds.org/docs/timestamps/ in mind.

kousu avatar Nov 04 '22 20:11 kousu

From a quick read, would this relate to this VERY old issue I opened ?

https://github.com/bids-standard/bids-specification/issues/136

Remi-Gau avatar Nov 07 '22 08:11 Remi-Gau

Yeah, looks like it.

effigies avatar Nov 07 '22 11:11 effigies