BentoML icon indicating copy to clipboard operation
BentoML copied to clipboard

feat: add timeout option for bentoml runner config

Open jjmachan opened this issue 3 years ago • 3 comments

What does this PR address?

Fixes #2888 eg

runners:
  timeout: 400 #seconds 

only global configuration is respected.

Before submitting:

Who can help review?

Feel free to tag members/contributors who can help review your PR.

jjmachan avatar Aug 10 '22 14:08 jjmachan

Codecov Report

Merging #2890 (6fc934b) into main (0e64c50) will decrease coverage by 0.88%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2890      +/-   ##
==========================================
- Coverage   70.77%   69.88%   -0.89%     
==========================================
  Files         104      121      +17     
  Lines        9470     9961     +491     
==========================================
+ Hits         6702     6961     +259     
- Misses       2768     3000     +232     
Impacted Files Coverage Δ
bentoml/_internal/runner/runner_handle/remote.py 88.54% <85.71%> (+0.36%) :arrow_up:
bentoml/_internal/configuration/containers.py 78.50% <100.00%> (ø)
bentoml/keras.py 0.00% <0.00%> (ø)
bentoml/mlflow.py 0.00% <0.00%> (ø)
bentoml/pytorch_lightning.py 0.00% <0.00%> (ø)
bentoml/pytorch.py 0.00% <0.00%> (ø)
bentoml/tensorflow.py 0.00% <0.00%> (ø)
bentoml/catboost.py 0.00% <0.00%> (ø)
bentoml/exceptions.py 93.33% <0.00%> (ø)
bentoml/xgboost.py 0.00% <0.00%> (ø)
... and 15 more

codecov[bot] avatar Aug 10 '22 14:08 codecov[bot]

I have not actually but can you tell me more about this compat layer?

jjmachan avatar Aug 10 '22 18:08 jjmachan

I have not actually but can you tell me more about this compat layer?

Oh just that running this on an older version of bentoml.

aarnphm avatar Aug 11 '22 01:08 aarnphm