BentoML
BentoML copied to clipboard
feat: add timeout option for bentoml runner config
What does this PR address?
Fixes #2888 eg
runners:
timeout: 400 #seconds
only global configuration is respected.
Before submitting:
- [ ] Does the Pull Request follow Conventional Commits specification naming? Here are GitHub's guide on how to create a pull request.
- [ ] Does the code follow BentoML's code style, both
make formatandmake lintscript have passed (instructions)? - [ ] Did you read through contribution guidelines and follow development guidelines?
- [ ] Did your changes require updates to the documentation? Have you updated those accordingly? Here are documentation guidelines and tips on writting docs.
- [ ] Did you write tests to cover your changes?
Who can help review?
Feel free to tag members/contributors who can help review your PR.
Codecov Report
Merging #2890 (6fc934b) into main (0e64c50) will decrease coverage by
0.88%. The diff coverage is87.50%.
@@ Coverage Diff @@
## main #2890 +/- ##
==========================================
- Coverage 70.77% 69.88% -0.89%
==========================================
Files 104 121 +17
Lines 9470 9961 +491
==========================================
+ Hits 6702 6961 +259
- Misses 2768 3000 +232
| Impacted Files | Coverage Δ | |
|---|---|---|
| bentoml/_internal/runner/runner_handle/remote.py | 88.54% <85.71%> (+0.36%) |
:arrow_up: |
| bentoml/_internal/configuration/containers.py | 78.50% <100.00%> (ø) |
|
| bentoml/keras.py | 0.00% <0.00%> (ø) |
|
| bentoml/mlflow.py | 0.00% <0.00%> (ø) |
|
| bentoml/pytorch_lightning.py | 0.00% <0.00%> (ø) |
|
| bentoml/pytorch.py | 0.00% <0.00%> (ø) |
|
| bentoml/tensorflow.py | 0.00% <0.00%> (ø) |
|
| bentoml/catboost.py | 0.00% <0.00%> (ø) |
|
| bentoml/exceptions.py | 93.33% <0.00%> (ø) |
|
| bentoml/xgboost.py | 0.00% <0.00%> (ø) |
|
| ... and 15 more |
I have not actually but can you tell me more about this compat layer?
I have not actually but can you tell me more about this compat layer?
Oh just that running this on an older version of bentoml.