mechanics icon indicating copy to clipboard operation
mechanics copied to clipboard

Port Types and Structs

Open bkc39 opened this issue 10 years ago • 3 comments

We need a port of the types and structs modules so that we can start making progress on the example code that doesn't have to do with display. I think that there should be a pretty drastic rewrite of their implementation to make it more idiomatic Racket code.

I say we break this down as follows:

  • [x] Initial port of types
  • [ ] Initial port of structs

Then once those are completed we need to

  • [ ] Replace the list-based Scheme structs with Racket structs.
  • [ ] Modify the types module so that a type is a property (in the sense of make-struct-property) of the structs
  • [ ] Replace the generic function implementation in the generic and generic-helper modules into actual Racket generics.
  • [ ] Come up with a better representation for up/down vectors that can preserve the existing API.

I think once this is done we can do most of the non-display example code in the first chapter and defer the display math and testing to #12 and #13, respectively.

bkc39 avatar Oct 08 '15 16:10 bkc39

Do we know what the existing API is? It wasn't clear to me, that's why I'm planning to follow the book in #13 and use that process to determine what types & structs we need.

bennn avatar Oct 08 '15 19:10 bennn

Yea. I've read through their code. I have a local branch that has started this. I'll like start a PR for this once its presentable.

bkc39 avatar Oct 08 '15 19:10 bkc39

too pro

feiranchen avatar Oct 09 '15 04:10 feiranchen