Ben Newman

Results 203 comments of Ben Newman

What versions of `react`/`react-dom` and `react-native` are you using? I ask because I don't think React Native is yet compatible with React 18, in case you tried upgrading.

@jmtimko5 Just in case it helps, can you try `npm i @apollo/client@next` (to get version 3.6.3)?

@karansinghgit This part looks a bit off to me: ``` let [client, setClient] = React.useState({} as ApolloClient); client = makeApolloClient("..."); setClient(client); ``` This means you're making a new `ApolloClient` instance...

@karansinghgit Ahh, I think the problem is that you're calling `useQuery` before you've created your `` component, so `useQuery` can't find any `ApolloProvider` above it in the component tree, and...

@Lana11s I think you're right it would be best to check the status code before parsing the JSON. I would be happy to review a PR if you have time...

@pkellner We can definitely keep discussing here, to be clear! And yes, we do plan either to provide additional suspenseful versions of the relevant hooks, or (if @capaj's [question above](https://github.com/apollographql/apollo-client/issues/9627#issuecomment-1119299194)...

Just to underscore @mxstbr's point, you lose nothing by documenting the tradeoffs honestly. If your users have to discover those tradeoffs themselves, they won't trust the project anymore, and they...

@octogonz I know I've kept you waiting on this for a long time, but I'm happy to say your changes were relatively easy to rebase, and aligned well with similar...

I've merged this into `master` so @eventualbuddha can try adding a def for `TSInstantiationExpression` to go with https://github.com/benjamn/recast/pull/1232. I will wait to publish a new version of `ast-types` to npm...

Thanks very much for noticing that. I can fix that and ping you when it's ready.