Ben Who comments

Results 34 comments of


                                            Ben Who

fix encode / decode by type to support branded ids

I believe it's a TypeORM issue: https://github.com/typeorm/typeorm/issues/5733 Please remove the `node_modules` folder, and run `npm install` with the `Node v10` before running the integration test.

fix encode / decode by type to support branded ids

> can I also ask the reason for using > > ``` > Reflect.getMetadata('design:type', this.entity.prototype, key).name.toLowerCase(); > ``` > > instead of > > ``` > Object.prototype.toString.call(key) > ``` It...

fix(Paginator-appendPagingQuery): if 'OR' directive exists, paging 'A…

Hi @masonCalmAndCode , Thanks for your contribution. Could you add a test to show the use case?

unknown type in cursor for branded ids

Hi @rares-lupascu Thanks for your feedback and propose your use case, the PR is welcome!

is it possible to add a custom sorting function to the tool ?

@Mr-Cool is right, use query builder to sort the results as usual then pass it to the paginator.

is it possible to add a custom sorting function to the tool ?

@HippolyteJacque @remithomas thanks for the reporting. Could you do me a little favor? Please try to use `.addOrderBy()` instead of `orderBy()` and see if it works. Thanks.

is it possible to add a custom sorting function to the tool ?

Hi @jimuelpalaca and @HippolyteJacque , Thanks for your feedback. I think the `addOrderBy()` must be appended right after the `orderBy()`, so I am planning to add custom order options to...

is it possible to add a custom sorting function to the tool ?

Hi @cjlynch12 , Sorry for the late reply. I'm still working on it, but I found that the TypeORM seems to have a bug on the `addOrderBy` nested column with...

QueryBuilder produces wrong SQL with order by + nested fields, breaks pagination-related queries with skip() and take()

Any possible solution to this issue?

QueryBuilder produces wrong SQL with order by + nested fields, breaks pagination-related queries with skip() and take()

@firxworx , thanks for your reply. Unfortunately, I'm trying to add a sorting feature to my library https://github.com/benjamin658/typeorm-cursor-pagination, and it relies on the query builder, so it's not possible to...