Ben Hoyt

Results 203 comments of Ben Hoyt

I think what I'll do here (at some point) is copy the `bufio.Scanner` implementation into the GoAWK codebase, add a `Buffered() io.Reader` method (similar to `encoding/json`'s [`Decoder.Buffered`](https://pkg.go.dev/encoding/json#Decoder.Buffered)), and then use...

Hi @xonixx, sorry for not replying sooner. This approach is along the lines of what I was thinking originally. However, on reflection it's quite invasive into the existing parsing code...

Note that my PR isn't intended for merging as is. I haven't gone over it in details, and it needs comments and tests. I'm happy for you to tidy it...

Hi @apockill -- good find, thanks. Would you be interested in creating a PR to fix it? Ideally we'd fix the code (should be a trivial fix) but also add...

Fixed by #11. Will release a new version to PyPI in the next week or so.

Hi @xonixx, wow, this looks very interesting -- nice work. I'll take a closer look later this week and get back to you.

I'll leave more comments later, but in the meantime I'm having trouble using `go tool cover` to view the report. ``` $ cat t.awk BEGIN { if (1) { print...

Thanks for that (it works). I've gone through your code, and have a few high-level thoughts. There are two approaches we could go here: 1) Leave coverage support in a...

All the best for you and your family -- war is like nothing we've experienced in far-away New Zealand. Yes, decoupling that in a separate PR sounds like the right...

This is done now, primarily in https://github.com/benhoyt/goawk/pull/154 -- thanks @xonixx!