Aegis icon indicating copy to clipboard operation
Aegis copied to clipboard

proposal: Importing Google Authenticator exports by image

Open orange-elephant opened this issue 3 years ago • 0 comments

Had a look at #933 This proposed fix minimises code duplication by passing the image scan uri result to the scanner activity as an extra. While this clearly needs improvement in error handling, I am submitting as is to check if this is an acceptable approach before putting more work in.

Also to consider, should the UX require all images of export codes at once like the camera equivalent or allow importing 1 image at a time and just displaying a message explaining which part has been imported?

orange-elephant avatar Aug 10 '22 00:08 orange-elephant

Had another look at this using the import multiple images functionality. Is this what you were thinking with regards to UX?

orange-elephant avatar Aug 11 '22 18:08 orange-elephant

Looks good! Could you squash your commits?

alexbakker avatar Aug 21 '22 12:08 alexbakker