Lucas Hosseini comments

Results 133 comments of


                                            Lucas Hosseini

Block for conditional field is always called

@ezekg So if you're still interested in fixing this, it's just a matter of delaying the `instance_eval`ing [here](https://github.com/jsonapi-rb/jsonapi-serializable/blob/master/lib/jsonapi/serializable/relationship.rb#L14) until either `as_jsonapi` or `related_resources` are called.

Issue with conditionals when extending base Serializable::Resource class directly in 0.2.1

Yeah you shouldn't extend the Serializable::Resource class itself directly but a subclass.

Issue with conditionals when extending base Serializable::Resource class directly in 0.2.1

Hmm I wasn't aware that you were customizing the base class. Would you mind issuing a PR re-modifying extensions to use prepend instead?

Issue with conditionals when extending base Serializable::Resource class directly in 0.2.1

Smart workaround! I'm currently away from machines but I'm keeping this under my radar On Wed, 9 Aug 2017 at 16:21, Lee Richmond wrote: > @beauby not wild about it,...

Fix for #80

Hi @daniel-sullivan – thanks for this PR! I'm currently on the road but will take a closer look asap 👍