json-schema-to-typescript icon indicating copy to clipboard operation
json-schema-to-typescript copied to clipboard

Interfaces now extend custom types

Open tivervac opened this issue 5 years ago • 6 comments

Replaces https://github.com/bcherny/json-schema-to-typescript/pull/212

tivervac avatar May 18 '20 14:05 tivervac

Since work on #212 appears to have stopped, I forked the commit rebased it and added a new test for the other test case in the thread.

tivervac avatar May 18 '20 14:05 tivervac

The CONTRIBUTING.md mentions that we should use node-inspector for debugging but it seems that package is deprecated, any new instructions on how to debug a test? Specifically I want to try and check on the comments you left on #212

tivervac avatar May 18 '20 14:05 tivervac

can we merge this

stephanrotolante avatar Oct 23 '20 20:10 stephanrotolante

@stephanrotolante We can once @bcherny approves my changes

tivervac avatar Oct 25 '20 14:10 tivervac

@tivervac I know, he's been M.I.A for quite some time now

stephanrotolante avatar Oct 25 '20 19:10 stephanrotolante

Sadly it seems like the API on master has changed quite a bit since the long time I wrote this. I have since long outgrown the need for this patch, or even library, and I have no more real life test case to test this again. Even just rebasing against master or answering some slightly deeper questions now seem like a burden. It doesn't look like I have the will, time or expertise to pick this up again. If anyone else is interested, feel free to use the code

tivervac avatar Jan 22 '21 16:01 tivervac