rules_ruby icon indicating copy to clipboard operation
rules_ruby copied to clipboard

Unable to find Rakefile when running rake ruby_binary

Open robertgates55 opened this issue 4 years ago • 5 comments

I'm trying to precompile my assets by creating a ruby_binary that runs rake assets:precompile.

I intend to then tar up the compiled assets and have the genrule output these (rather than test.txt!)

My BUILD goes like this:

ruby_library(
    name = "assets_precompile_lib",
    srcs = glob(
        include = [
            "app/**/*",
            "config/**/*",
            "lib/**/*",
            "vendor/assets/**/*",
        ],
    ) + [
        "Rakefile"
    ],
    deps = [
        "@bundle//:gems",
    ],
)

ruby_binary(
    name = "assets_precompile_bin",
    srcs = [":assets_precompile_lib"],
    args = ["assets:precompile"],
    includes = [
        "src/webapp/Rakefile",
    ],
    main = "@bundle//:bin/rake",
    deps = ["@bundle//:gems"],
)

genrule(
    name = "test",
    srcs = ["Rakefile"],
    outs = ["test.txt"],
    cmd = """
        $(location :assets_precompile_bin)
        echo "test" > $@
    """,
    local = 1,
    message = "test",
    tools = [
        ":assets_precompile_bin",
    ],
    visibility = ["//visibility:public"],
)

But when I run the genrule I get:

➜  bazel build //src/webapp:test
INFO: Analyzed target //src/webapp:test (1 packages loaded, 1740 targets configured).
INFO: Found 1 target...
ERROR: /Users/robert.gates/Repositories/cube/src/webapp/BUILD:698:8: test //src/webapp:test failed: (Exit 1): bash failed: error executing command /bin/bash -c ... (remaining 1 argument skipped)
rake aborted!
No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)
/private/var/tmp/_bazel_robert.gates/dc10ae55cdaa28397da3989c20f911cb/external/bundle/lib/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
(See full trace by running task with --trace)
Target //src/webapp:test failed to build
Use --verbose_failures to see the command lines of failed build steps.

Could anyone help me understand what's wrong here? I've included the Rakefile in the lib, and also tried getting it onto the LOAD_PATH with includes = but no luck. Any advice really appreciated!

robertgates55 avatar Apr 08 '22 17:04 robertgates55

Have simplified the rules to:


ruby_binary(
    name = "assets_precompile_bin",
    srcs = glob(
        include = [
            "app/**/*",
            "config/**/*",
            "lib/**/*",
            "vendor/assets/**/*",
        ],
    ) + [
        "Rakefile",
    ],
    args = [
        "-- assets:precompile",
    ],
    main = "@bundle//:bin/rake",
    deps = [
        "@bundle//:bin",
        "@bundle//:gems",
    ],
)

genrule(
    name = "precompile",
    outs = ["assets.tar.gz"],
    cmd = """
        $(location :assets_precompile_bin)
        echo "test" > $@
    """,
    tools = [
        ":assets_precompile_bin",
    ],
    visibility = ["//visibility:public"],
)

(is that better?)

but get the same error.

robertgates55 avatar Apr 08 '22 17:04 robertgates55

I'm really interested in getting rake to work as well. Subscribing to this ticket.

shepting avatar Apr 13 '22 22:04 shepting

Could you try including Rakefile in the include hash instead of appending it afterwards?

kigster avatar May 12 '22 19:05 kigster

Could you create a branch and add a new folder under examples wjth this test case?

kigster avatar May 12 '22 19:05 kigster

Looking for additional core maintainers: https://github.com/bazelruby/rules_ruby/discussions/146

kigster avatar May 10 '23 17:05 kigster