rules_swift

rules_swift copied to clipboard

Update grpc-swift and dependencies

1

The current grpc-swift repo rule is very outdated with newer versions containing bug fixes and significant enhancements (async/await support, UDS, etc.). This PR bumps the grpc-swift version to the latest...

tylervick

Add generate_internal_visibility_from_proto_files feature

1

Fixes #961 **Change** Create a new feature `swift.generate_internal_visibility_from_proto_files` which will set protoc's swift_opt `Visibility` from `Public` to `Internal`. **Test** - Create a valid rule for `swift_grpc_library` or `swift_proto_library` - Verify...

tylervick

Flaky toolchain resolution

12

I occasionally see this error: ``` ERROR: /private/var/tmp/_bazel_runner/38952b[62](https://github.com/envoyproxy/envoy/actions/runs/3651410480/jobs/6168700603#step:5:63)5e1e7c72284b0f9be4a35639/external/build_bazel_rules_swift_local_config/BUILD:9:22: While resolving toolchains for target @build_bazel_rules_swift_local_config//:toolchain: No matching toolchains found for types @bazel_tools//tools/cpp:toolchain_type. ``` The fact that `@build_bazel_rules_swift_local_config//:toolchain` is in the error...

jpsim

[swift_proto_library] Generated types are always public

1

Currently the [`Visibility` generation option](https://github.com/apple/swift-protobuf/blob/main/Documentation/PLUGIN.md#generation-option-visibility---visibility-of-generated-types) is hardcoded to `Public` for all protobuf generation: https://github.com/bazelbuild/rules_swift/blob/7ea19709611d40776f05bf6d35b950e1d1a3a506/swift/internal/swift_protoc_gen_aspect.bzl#L185 Certain use cases require a non-public access level for generated objects. For example, when creating a...

tylervick

Incremental compilation issue? `output 'foo.swiftinterface' was not created`

5

This is a possible incremental compilation issue that I often run into when building [Envoy Mobile](https://github.com/envoyproxy/envoy/blob/main/mobile/README.md). ```console $ ./bazelw build --config=ios //library/swift:ios_framework DEBUG: /private/var/tmp/_bazel_jsimard/e99b8d924fe95f277e909ecdb8681535/external/rules_python/python/pip.bzl:46:10: pip_install is deprecated. Please switch to...

jpsim

Character encoding issue with international filenames.

3

Hi, I've been chasing an issue where: if I include a swift file such as (for example) `a 进行正式友好访问 2.swift` in a source directory and bring it in using either...

johnno1962

``` There was a 'swift-dependencies' entry for , but the build rules should not have done this; ignoring it. There was a 'swift-dependencies' entry for external/com_github_tadija_aexml/Sources/AEXML/Document.swift, but the build rules...

brentleyjones

This flag can be used when emitting a symbol graph to additionally include the symbols from the extension blocks. This is useful when generating documentation with DocC so that the...

luispadron

This is similar to `swift_library_group`, in that it allows you to group multiple `swift_compiler_plugin` targets under a single target. This is needed to support SPM’s `plugin` products, which support multiple...

brentleyjones

Using the two opt-out features via #1179, builds may fail if not cleaned before opting out of these features: ``` build --features=-swift.emit_swiftsourceinfo build --features=-swift.emit_swiftdoc ``` ``` :0: error: error opening...

erikkerber